HADOOP-19717. Resolve build error caused by missing Checker Framework (NonNull not recognized). #8015
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (NonNull not recognized).
4 tasks
pan3793
reviewed
Oct 7, 2025
|
|
||
| import org.apache.hadoop.util.Preconditions; | ||
| import org.checkerframework.checker.nullness.qual.Nullable; | ||
| import org.apache.hadoop.thirdparty.org.checkerframework.checker.nullness.qual.Nullable; |
There was a problem hiding this comment.
I suspect this makes the Nullable useless, I don't think the static analyzer tools can recognize such a relocated annotation.
There was a problem hiding this comment.
I think what you said makes some sense, but there are similar users in AzureBFS as well.
@steveloughran I’d like to hear your thoughts — do you think we should reintroduce a new dependency to resolve the issue where org.checkerframework.checker.nullness.qual.Nullable cannot be found?
cc: @szetszwo
There was a problem hiding this comment.
... this makes the Nullable useless, ...
Making it useless seems better than breaking the build.
Unforturately, the the builds after this remain failing.
|
💔 -1 overall
This message was automatically generated. |
slfan1989
force-pushed
the
HADOOP-19717
branch
from
aca0e73 to
f0c771f
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@szetszwo @pan3793 My thought is that since For now, we can use A follow-up PR can be submitted later to fully resolve this dependency problem in a cleaner way. Currently, the build result is as expected — before applying this patch, the trunk could not compile successfully, but after merging it, the build now passes under both JDK 8 and JDK 11. |
|
@slfan1989 , if it can fix the build, then it is fine. But the builds after this remain failing. |
@szetszwo A new issue occurred during the compilation of yarn-ui. The log output is as follows: I tried to apply a local fix for this issue. |
szetszwo
approved these changes
Oct 7, 2025
I manually specified |
|
@szetszwo Thank you very much for the review! |
|
@slfan1989 , thanks for fixing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: HADOOP-19717. Resolve build error caused by missing Checker Framework (NonNull not recognized).
#8011 raised an issue: the build failed on the trunk branch with the following error
This is related to the Guava version upgrade in the trunk.
The dependency
org.checkerframework:checker-qual:jarcannot be imported.We can use
org.apache.hadoop.thirdparty.org.checkerframework.checker.nullness.qual.NonNullas a replacement fororg.checkerframework.checker.nullness.qual.NonNull.How was this patch tested?
CI.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?